Jiangli, Looks good for me.
SymbolTable.java 97 I would prefer to just return sharedTable.probe(name, hashValue); to avoid unnecessary changes, but it's not a concern - you can leave it as is. -Dmitry On 2015-01-30 04:13, Jiangli Zhou wrote: > Hi, > > Please review the change for JDK-8071962, "The SA code needs to be updated to > support Symbol lookup from the shared archive”. > > In JDK-8059510, we introduced a compact form of hash table for the symbols in > shared archive. The shared symbols are stored separately from the regular > symbol table. The VM looks up both tables when searching for existing symbol > at runtime. The SA code needs to do the same when looking up symbols. > > Webrev: http://cr.openjdk.java.net/~jiangli/8067977/webrev.00/ > > Tested on both 32-bit and 64-bit platforms: > bin/java sun.jvm.hotspot.tools.DumpJFR <pid> > > JPRT tests in progress. > > Thanks, > Jiangli > > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
