Re: RFR(XS): 8072401, 8072403, 8072405: Small fixes to newly added DCMD tests

[Mikael Auno]

Thanks for the review. Could you help push this for me? The exported
changsets are attached.

Thanks,
Mikael

On 2015-02-03 16:44, Jaroslav Bachorik wrote:
> Looks good.
> 
> -JB-
> 
> On 3.2.2015 16:27, Mikael Auno wrote:
>> Hi, could I please have some reviews for these very small fixes.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~miauno/8072401_8072403_8072405/webrev.00/
>>
>> Issues:
>>
>> Some of the newly added DCMD tests fail due to lack of -XX:+UsePerfData
>> https://bugs.openjdk.java.net/browse/JDK-8072401
>>
>> HeapDumpTest and HeapDumpAllTest fails to find jhat in non-JDK runs
>> https://bugs.openjdk.java.net/browse/JDK-8072403
>>
>> DCMD tests needs at least compact3 profile
>> https://bugs.openjdk.java.net/browse/JDK-8072405
>>
>> Thanks,
>> Mikael
>>
> 


# HG changeset patch
# User miauno
# Date 1422962800 -3600
# Node ID 01cc42eb107afca5408e30a0a09c251be7976b98
# Parent  190387dac81353a3bc1dddbb328a60f2cb85500a
8072401: [TESTBUG] Some of the newly added DCMD tests fail due to lack of -XX:+UsePerfData
Reviewed-by: jbachorik

diff --git a/test/serviceability/dcmd/framework/HelpTest.java b/test/serviceability/dcmd/framework/HelpTest.java
--- a/test/serviceability/dcmd/framework/HelpTest.java
+++ b/test/serviceability/dcmd/framework/HelpTest.java
@@ -35,7 +35,7 @@
  * @library /testlibrary
  * @build com.oracle.java.testlibrary.*
  * @build com.oracle.java.testlibrary.dcmd.*
- * @run testng HelpTest
+ * @run testng/othervm -XX:+UsePerfData HelpTest
  */
 public class HelpTest {
     public void run(CommandExecutor executor) {
diff --git a/test/serviceability/dcmd/framework/InvalidCommandTest.java b/test/serviceability/dcmd/framework/InvalidCommandTest.java
--- a/test/serviceability/dcmd/framework/InvalidCommandTest.java
+++ b/test/serviceability/dcmd/framework/InvalidCommandTest.java
@@ -35,7 +35,7 @@
  * @library /testlibrary
  * @build com.oracle.java.testlibrary.*
  * @build com.oracle.java.testlibrary.dcmd.*
- * @run testng InvalidCommandTest
+ * @run testng/othervm -XX:+UsePerfData InvalidCommandTest
  */
 public class InvalidCommandTest {
 
diff --git a/test/serviceability/dcmd/framework/VMVersionTest.java b/test/serviceability/dcmd/framework/VMVersionTest.java
--- a/test/serviceability/dcmd/framework/VMVersionTest.java
+++ b/test/serviceability/dcmd/framework/VMVersionTest.java
@@ -36,7 +36,7 @@
  * @library /testlibrary
  * @build com.oracle.java.testlibrary.*
  * @build com.oracle.java.testlibrary.dcmd.*
- * @run testng VMVersionTest
+ * @run testng/othervm -XX:+UsePerfData VMVersionTest
  */
 public class VMVersionTest {
     public void run(CommandExecutor executor) {
# HG changeset patch
# User miauno
# Date 1422964153 -3600
# Node ID bca4aed2d75f4025d3d0929235d88155e36a0731
# Parent  01cc42eb107afca5408e30a0a09c251be7976b98
8072403: [TESTBUG] HeapDumpTest and HeapDumpAllTest fails to find jhat in non-JDK runs
Reviewed-by: jbachorik

diff --git a/test/serviceability/dcmd/gc/HeapDumpTest.java b/test/serviceability/dcmd/gc/HeapDumpTest.java
--- a/test/serviceability/dcmd/gc/HeapDumpTest.java
+++ b/test/serviceability/dcmd/gc/HeapDumpTest.java
@@ -51,7 +51,7 @@
     }
 
     private void verifyHeapDump(String fileName) {
-        String jhat = JDKToolFinder.getTestJDKTool("jhat");
+        String jhat = JDKToolFinder.getJDKTool("jhat");
         String[] cmd = { jhat, "-parseonly", "true", fileName };
 
         ProcessBuilder pb = new ProcessBuilder(cmd);
# HG changeset patch
# User miauno
# Date 1422964173 -3600
# Node ID 926a6fbb8d1ab01ef64e93b817f4c60705d5e37f
# Parent  bca4aed2d75f4025d3d0929235d88155e36a0731
8072405: [TESTBUG] DCMD tests needs at least compact3 profile
Reviewed-by: jbachorik

diff --git a/test/TEST.groups b/test/TEST.groups
--- a/test/TEST.groups
+++ b/test/TEST.groups
@@ -145,7 +145,8 @@
   gc/survivorAlignment \
   runtime/InternalApi/ThreadCpuTimesDeadlock.java \
   serviceability/threads/TestFalseDeadLock.java \
-  compiler/codecache/jmx
+  compiler/codecache/jmx \
+  serviceability/dcmd
 
 # Compact 2 adds full VM tests
 compact2 = \