Jaroslav Bachorik wrote:
Hi Shanliang,

Looks good! A lot of work here ...

Just a nit -

* jdk/src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandInfo.java
  - superfluous import @L28 (and the copyright year change)
Yes the import of L28 is unnecessary.
The copyright year was changed because the package was changed.

I suppose all reg-tests and related JCK tests are still passing.
I passed svc/core/hotspot unit tests with jprt, and JMX JCK tests.

Thanks for the review.
Shanliang

-JB-

On 31.3.2015 18:39, shanliang wrote:
Please review this fix:

Bug: https://bugs.openjdk.java.net/browse/JDK-8042901
Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8042901/00/

Some code within the module java.management is separated and moved to
the new module jdk.management, the new module takes the implementation
code for Oracle Corporation's platform extension to the implementation
of the java.lang.management API and also the management interface for
some other components for the platform.

Thanks,
Shanliang



Reply via email to