Jaroslav, Staffan,
Thanks for the reviews!
// Katja
On 04/07/2015 03:55 PM, Jaroslav Bachorik wrote:
Looks fine!
You might want to convert the 'jstatd started (bound to' string to a
constant to make it easier to track any changes in the future but it
is up to you. I am fine with the changes anyway.
-JB-
On 7.4.2015 14:52, Yekaterina Kantserova wrote:
Hi,
The updated webrev can be found here:
http://cr.openjdk.java.net/~ykantser/8027668/webrev.01/
Thanks,
Katja
On 04/02/2015 02:44 PM, Jaroslav Bachorik wrote:
Hi Katja,
On 2.4.2015 14:16, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8027668
webrev: http://cr.openjdk.java.net/~ykantser/8027668/webrev.00/
In src/jdk.jvmstat/share/classes/sun/tools/jstatd/Jstatd.java I would
suggest adding System.out.flush() after printing "jstatd is started on
..." to make sure the output is actually committed to stdout.
Please, update the copyright years.
-JB-
The tests can still contain a race. There is a possibility the
jstad is
not really started though there is a pid for the process. The
suggestion
is to let jstatd notify it's started and for the test wait until this
notification.
Thanks,
Katja
