On 05/05/2015 02:04 AM, Yekaterina Kantserova wrote:
Hi,

Could I please have a review of this fix.

bug: https://bugs.openjdk.java.net/browse/JDK-8078896
webrev: http://cr.openjdk.java.net/~ykantser/8078896


com.sun.management has been moved to jdk.management module. The patch for JDK-8042901 is just integrated in jdk9/dev today. Most, if not all, test/com/sun/management tests need updates to require @modules jdk.management.

There are several test/java/lang/management tests dependng on both java.lang.management and com.sun.management. For tests only using java.lang.management API, @modules java.management is adequate.

test/com/sun/jdi/InterfaceMethodsTest.java
test/com/sun/jdi/InterruptHangTest.java
Since you have updated the end year of the copyright header in most tests, I spot a couple and so mention it to you.

Otherwise looks good.  Thanks for doing this.

Mandy

Reply via email to