> > But, seriously, why didn’t you like my proposal? It can do anything your > scheme can with fewer and simpler code changes. The only thing that it cannot > do is to sample based on object count (i.e., every 100 objects) instead of > based on object size (i.e., every 1MB of allocations). But I think doing > sampling based on size is the right approach here (IMHO). > >
I would think that the size based sampling would create a size based bias in your sampling. Since IME, it’s allocation frequency is more damaging to performance, I’d prefer to see time boxed sampling Kind regards, Kirk Pepperdine
