I'll add a third Review :) My only query is whether just type2name is the right choice here - I'm not sure what the actual output will display in context?

Thanks,
David

On 15/07/2015 2:21 AM, Daniel D. Daugherty wrote:
 > Webrev: http://cr.openjdk.java.net/~vkempik/8048353/webrev.00/

src/share/vm/classfile/javaClasses.cpp
     No comments. (Thanks for including the "<null>" case.)

src/share/vm/classfile/javaClasses.hpp
     No comments.

src/share/vm/runtime/vframe.cpp
     No comments.

Thumbs up (modulo running the proper tests).

Dan


On 7/14/15 9:56 AM, Daniel D. Daugherty wrote:
Adding serviceability-dev@... since jstack belongs to the
Serviceability team...

The jstack and/or tmtools tests should also be run...

Dan


On 7/14/15 9:51 AM, Vladimir Kempik wrote:
Hello,

Please review the patch to fix 8048353.
Customer has an issue with this bug when running jstack on jdk7.
He tested FVB and cofirmed it has fixed the issue.
Before pushing jdk7 backport I need to get the fix to 9 and 8.

Webrev: http://cr.openjdk.java.net/~vkempik/8048353/webrev.00/
JBS bug: https://bugs.openjdk.java.net/browse/JDK-8048353

testing: JPRT.

Thanks, Vladimir.


Reply via email to