Hi Serguei,
Thanks a lot for looking at it! Yes, I unintentionally removed
test/demo/jvmti instead of test/demo/jvmti/hprof :( Will restore the
tests asap.
// Katja
On 07/15/2015 11:58 AM, serguei.spit...@oracle.com wrote:
Hi Katya,
On 7/15/15 2:22 AM, Yekaterina Kantserova wrote:
Hi,
I've forgotten to remove serviceability/hprof/cpu002.java test in
hotspot repo. Could I please have a review for this change?
webrev: http://cr.openjdk.java.net/~ykantser/8076471.hotspot/webrev.00
This looks good.
Thanks,
Katja
On 07/10/2015 02:55 PM, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8076471
webrev: http://cr.openjdk.java.net/~ykantser/8076471/webrev.00
It looks good but I'm not sure why have you deleted these tests as well:
|------ ------ ------ ------ Old
<http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/minst/MinstExample.java-.html>
--- ----- --- | *test/demo/jvmti/minst/MinstExample.java*
|------ ------ ------ ------ Old
<http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/minst/MinstTest.java-.html>
--- ----- --- | *test/demo/jvmti/minst/MinstTest.java*
|------ ------ ------ ------ Old
<http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/versionCheck/FailsWhenJvmtiVersionDiffers.java-.html>
--- ----- --- |
*test/demo/jvmti/versionCheck/FailsWhenJvmtiVersionDiffers.java*
|------ ------ ------ ------ Old
<http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/waiters/WaitersTest.java-.html>
--- ----- --- | *test/demo/jvmti/waiters/WaitersTest.java*
Did you want to remove all the demo tests, not hprof only?
Just want to make sure you did not get rid of them unintentionally.
Thanks,
Serguei
More details can be found in JEP 240: Remove the JVM TI hprof Agent
(https://bugs.openjdk.java.net/browse/JDK-8046661).
Thanks,
Katja
