Hi Serguei,
On 7/23/15 2:35 AM, serguei.spit...@oracle.com wrote:
Coleen,
The fix looks good in general.
There is one more place where the same may need to be fixed.
It is in the function java_lang_StackTraceElement::create ():
1911 // Fill in source file name and line number.
1912 // Use specific ik version as a holder since the mirror might
1913 // refer to version that is now obsolete and no longer accessible
1914 // via the previous versions list.
1915 holder = holder->get_klass_version(version);
1916 assert(holder != NULL, "sanity check");
1917 Symbol* source = holder->source_file_name();
I did change both places, I think you're looking at the old version.
java_lang_StackTraceElement::create() was where the crash was.
thanks for getting to this so quickly.
Coleen
I'm still reviewing the test.
Thanks,
Serguei
On 7/22/15 10:22 AM, Coleen Phillimore wrote:
Summary: Need to get source_file_name from the_class's constant pool
not previous version constant pool
open webrev at http://cr.openjdk.java.net/~coleenp/8087315.01/
bug link https://bugs.openjdk.java.net/browse/JDK-8087315
Tested with added test (yay!), RBT (remote build and test),
vm.redefine.testlist, jdk/test/java/lang/instrument and failing
testcase 1000 times (reproduced <400).
Thanks,
Coleen
