Good!

> On 4 sep 2015, at 12:21, Jaroslav Bachorik <jaroslav.bacho...@oracle.com> 
> wrote:
> 
> On 2.9.2015 20:44, Staffan Larsen wrote:
>> Looks good, but needs a test.
> 
> I've modified the 'jps' generic test to exercise multi-lined properties.
> 
> http://cr.openjdk.java.net/~jbachorik/8134420/webrev.01
> 
> -JB-
> 
>> 
>>> On 2 sep 2015, at 20:21, Jaroslav Bachorik <jaroslav.bacho...@oracle.com> 
>>> wrote:
>>> 
>>> Please, review the following change
>>> 
>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8134420
>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8134420/webrev.00
>>> 
>>> Currently, 'jps' will print multi-line vm args as they are - eg. splitting 
>>> the output into multiple lines. This kind of output is not very easy to 
>>> read and, incidentally, it can break this test.
>>> 
>>> My proposal is to replace all '\n' and '\r' characters with "\n" and "\r" 
>>> strings respectively to keep the output format being 'one line per one JVM'.
>>> 
>>> Thanks,
>>> 
>>> -JB-
>> 
> 

Reply via email to