Looks good! Thanks, /Staffan
> On 20 nov. 2015, at 13:29, Marcus Larsson <marcus.lars...@oracle.com> wrote: > > Need another review for this! > > Thanks, > Marcus > > On 2015-11-13 10:20, Marcus Larsson wrote: >> Hi, >> >> Please review the following small patch to avoid 'unused variable' warnings >> on windows when only static functions are used on a log instance. Using log >> instances like this saves us from specifying the log tags for every function >> call, so it is something we should not warn about. >> >> The patch adds an empty constructor, which means that at least one >> non-static function is called for every log instance, and the warning is >> avoided. >> >> Webrev: >> http://cr.openjdk.java.net/~mlarsson/8142483/webrev.00/ >> <http://cr.openjdk.java.net/%7Emlarsson/8142483/webrev.00/> >> >> Issue: >> https://bugs.openjdk.java.net/browse/JDK-8142483 >> <https://bugs.openjdk.java.net/browse/JDK-8142483> >> >> Thanks, >> Marcus >
