Thanks for reviewing, Staffan!
Marcus
On 2015-11-26 16:54, Staffan Larsen wrote:
Looks good!
Thanks,
/Staffan
On 26 nov. 2015, at 16:17, Marcus Larsson <marcus.lars...@oracle.com> wrote:
Hi,
New webrev after offline review with Bengt and Staffan:
http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/
Incremental:
http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/
Changes:
* LogLevel::Unchanged was changed to LogLevel::NotMentioned.
* Test improvements.
I also looked at FormatBuffers for the string handling in LogOutput, but
unfortunately they are sized according to template parameters and hence don't
play well with the dynamic expansion required here.
Thanks
Marcus
On 2015-11-24 11:46, Marcus Larsson wrote:
Hi,
Please review the following patch to enable multiple -Xlog arguments to
aggregate the log configuration.
Summary:
Tag sets that are unaffected by a -Xlog argument will now be left untouched,
enabling them to keep settings from a previous -Xlog argument.
To be able to print the current log configuration, the _config_string on
LogOutputs has to be derived from each enabled tag set and its level, instead
of the previous copying of the -Xlog argument. This means that -Xlog:all:stdout
sets the _config_string for stdout to the explicit list of all tag sets in the
VM, with level set to info.
Webrev:
http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00/
Issue:
https://bugs.openjdk.java.net/browse/JDK-8142952
Testing:
Included test through JPRT.
Thanks,
Marcus
