On 14.12.2015 08:15, Harsha Wardhana B wrote:
Hello,
Please review the fix for bug JDK-7065236.
Issue :
<http://cr.openjdk.java.net/%7Ejbachorik/sponsorship/7065236/webrev.00>https://bugs.openjdk.java.net/browse/JDK-7065236
Webrev : http://cr.openjdk.java.net/~jbachorik/sponsorship/7065236/webrev.00
In order to fix the bug, below were the list of occurrences that needed
to be examined for Locale sensitive case conversions.
./javax/management/modelmbean/DescriptorSupport.java: final String
lowerInStr = inStr.toLowerCase(); ---- Yes
./javax/management/modelmbean/DescriptorSupport.java:
descriptor.put(entry.getKey().toLowerCase(), entry.getValue()); ---- No
./javax/management/remote/JMXServiceURL.java:
serviceURL.substring(protoStart, protoEnd).toLowerCase(); ---- Yes
./javax/management/remote/JMXServiceURL.java: this.protocol =
protocol.toLowerCase(); ---- Yes
./javax/management/loading/MLetParser.java: atts.put(att.toLowerCase(),
val); ---- Yes
./javax/management/loading/MLetContent.java: return
attributes.get(name.toLowerCase()); ---- Private
Method. Not required
./com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java: return
name.substring(0, offset1).toLowerCase() + ---- No
./com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java: return
name.substring(0, offset1).toUpperCase() + ---- No
./com/sun/jmx/mbeanserver/Util.java: hash +=
names[i].toLowerCase().hashCode(); ---- No
The occurrences of case conversions marked as 'Yes' were deemed to be
Locale Insensitive and hence only those were fixed. Please review and
let me know if any other occurrences marked as 'No' also needs to be fixed.
The fix looks good.
-JB-
Thanks
Harsha
