On Thu, 2016-01-21 at 18:03 +0100, Daniel Fuchs wrote: > On 21/01/16 15:20, Severin Gehwolf wrote: > > Thanks, Jaroslav. Any JDK 8 reviewer willing to have a look at this? > > Looks good to me Severin.
Thank you, Daniel! Cheers, Severin > best regards, > > -- daniel > > > > Thanks, > > Severin > > > > On Thu, 2016-01-21 at 12:01 +0100, Jaroslav Bachorik wrote: > > > On 21.1.2016 11:30, Severin Gehwolf wrote: > > > > Hi, > > > > > > > > Could somebody please review and sponsor this small 8u bugfix? This bug > > > > has been introduced with the January 2016 CPU fixes (JDK-8130710) and > > > > I've not seen this code in JDK 9 (yet?). Hence, posting this here. > > > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8147857 > > > > webrev: > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8147857/webrev.01/ > > > > > > > > The fix for non-public bug JDK-8130710 uses Collectors.joining() for > > > > assembling the list of attribute names when they get logged. However, > > > > the arguments are passed in to Collectors.joining() incorrectly, which > > > > results in log messages like this: > > > > > > > > attribute names=', FirstName[LastName]' > > > > > > > > where it should be this: > > > > > > > > attribute names='[FirstName, LastName]' > > > > > > > > The fix is to swap the arg for the delimiter and the prefix args. I've > > > > included a regression test. > > > > > > > > Testing done: jdk_jmx tests fail without the fix and pass after. > > > > > > > > Thoughts? > > > > > > Nice catch. And good work fixing it with a nice test! > > > Looks good, not a JDK 8 *R*eviewer, though. > > > > > > -JB- > > > > > > > > > > > Thanks, > > > > Severin > > > > > > > > > >
