Hi Sharath,

On 1/03/2016 2:39 AM, Sharath Ballal wrote:
Hi David,
I have created a java testcase.  The webrev link is:

http://cr.openjdk.java.net/~jbachorik/sponsorship/8147456/webrev.04/

Seems fine. Just fix the copyright year:

 Copyright (c) 2003, 2016,

Should only be 2016 for this new file.

Thanks,
David


-Sharath Ballal



-----Original Message-----
From: David Holmes
Sent: Tuesday, February 23, 2016 7:15 AM
To: Sharath Ballal; serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8147456 Parsing of argument for -agentpath can write outside 
of allocated memory

Hi Sharath,

On 23/02/2016 12:59 AM, Sharath Ballal wrote:
Hi,

Pls review the fix for the following bug.

Bug: https://bugs.openjdk.java.net/browse/JDK-8147456
Webrev:
http://cr.openjdk.java.net/~jbachorik/sponsorship/8147456/webrev.03/

The functional fix seems fine.

But for the test I understand we are moving away from using shell scripts, so 
can you please create a Java test using the Process* API's in the test library.

Thanks,
David

-Sharath Ballal

Reply via email to