Yasumasa, 91 s/perfromance/performance/
Test: 146 launch("compiler detected.", "jsnap"); Please, choose expectedMessage carefully, I'm not sure "compiler detected." is an appropriate one. -Dmitry On 2016-03-03 18:45, Yasumasa Suenaga wrote: > Hi Dmitry, > > Thank you for your comment. > I uploaded new webrev: > > hotspot: http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.01/hotspot/ > jdk: http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.01/jdk/ > > > Could you review again? > > > Thanks, > > Yasumasa > > > On 2016/03/04 0:15, Dmitry Samersoff wrote: >> Yasumasa, >> >> It's better (with upcoming changes for JDK-8148659 in mind) to create a >> separate >> >> private static boolean jsnapHelp() { >> System.out.println(" <no option>\tdump perfromance counters"); >> return commonHelp(); >> } >> >> and write: >> >> System.out.println(" jsnap --help\tto get more information"); >> >> Please also update: >> >> jdk/test/sun/tools/jhsdb/BasicLauncherTest.java >> >> -Dmitry >> >> >> On 2016-03-03 17:43, Yasumasa Suenaga wrote: >>> Hi all, >>> >>> JSnap is useful SA tool to check PerfCounter. >>> So I want to add it to jhsdb. >>> >>> http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.00/ >>> >>> Could you review it? >>> >>> >>> Thanks, >>> >>> Yasumasa >>> >> >> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.