Yasumasa, Looks good for me.
-Dmitry On 2016-03-14 17:12, Yasumasa Suenaga wrote: > Hi, > >> I guess JDK-8151181: Add JSnap to jhsdb is in progress. >> JDK-8151709 is affected it. >> So I want to send review request after that. > > JDK-8151181 is merged. > So I uploaded new webrev. Could you review it? > > hotspot: http://cr.openjdk.java.net/~ysuenaga/JDK-8151709/webrev.03/hotspot/ > jdk: http://cr.openjdk.java.net/~ysuenaga/JDK-8151709/webrev.03/jdk/ > > > Thanks, > > Yasumasa > > > On 2016/03/14 12:58, Yasumasa Suenaga wrote: >> Hi Dmitry, >> >> I changed for arguments processing in jhsdb in new webrev: >> hotspot: >> http://cr.openjdk.java.net/~ysuenaga/JDK-8151709/webrev.02/hotspot/ >> jdk: http://cr.openjdk.java.net/~ysuenaga/JDK-8151709/webrev.02/jdk/ >> >> I encountered ArrayIndexOutOfBoundsException when I ran `jhsdb jstack --pid`. >> So I fix its problem. >> >> >> I guess JDK-8151181: Add JSnap to jhsdb is in progress. >> JDK-8151709 is affected it. >> So I want to send review request after that. >> >> >> Thanks, >> >> Yasumasa >> >> >> On 2016/03/13 23:52, Dmitry Samersoff wrote: >>> Yasumasa, >>> >>> 1. >>> We shouldn't introduce dependency from Tool.java back to SALuancher. >>> >>> So please, change runJSTACK (and other similar functions) to catch >>> invalid arguments. >>> >>> It might require changing of SAGetopt.java and/or >>> jdk/test/sun/tools/jhsdb/SAGetoptTest.java >>> >>> 2. For JInfo changes, please create >>> >>> private static final int MODE_UNKNOWN = -1; >>> >>> >>> -Dmitry >>> >>> >>> On 2016-03-12 17:33, Yasumasa Suenaga wrote: >>>> I updated webrev: >>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8151709/webrev.01/ >>>> >>>> I added changes for JInfo.java because help message is shown in twice. >>>> >>>> Please review. >>>> >>>> >>>> Thanks, >>>> >>>> Yasumasa >>>> >>>> >>>> On 2016/03/11 22:26, Yasumasa Suenaga wrote: >>>>> Hi all, >>>>> >>>>> jhsdb shows error message in each tool implemantation as below: >>>>> -------------- >>>>> $ jhsdb jstack -aaa >>>>> Usage: jstack [option] <pid> >>>>> (to connect to a live java process) >>>>> or jstack [option] <executable> <core> >>>>> (to connect to a core file) >>>>> or jstack [option] [server_id@]<remote server IP or hostname> >>>>> (to connect to a remote debug server) >>>>> >>>>> where option must be one of: >>>>> -l to print java.util.concurrent locks >>>>> -m to print both java and native frames (mixed mode) >>>>> -h | -help to print this help message >>>>> -------------- >>>>> >>>>> If we run SA tool via jhsdb, we should get help message of SALauncher as >>>>> below: >>>>> -------------- >>>>> $ jhsdb jstack -aaa >>>>> --locks to print java.util.concurrent locks >>>>> --mixed to print both java and native frames (mixed mode) >>>>> --exe executable image name >>>>> --core path to coredump >>>>> --pid pid of process to attach >>>>> -------------- >>>>> >>>>> I uploaded webrev. Could you review it? >>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8151709/webrev.00/ >>>>> >>>>> I cannot access JPRT. >>>>> So I need a Sponsor. >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> Yasumasa >>>>> >>> >>> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
