Hi Robbin,
Thanks for filing the RFE.
Bengt
On 2016-03-17 11:51, Robbin Ehn wrote:
Hi Bengt
Thanks for your input.
On 03/16/2016 11:38 AM, Bengt Rutisson wrote:
Hi Robbin,
On 2016-03-15 21:31, Robbin Ehn wrote:
Hi, please review this enhancement.
This adds support for multiple UL tags in TraceTime.
Bug: https://bugs.openjdk.java.net/browse/JDK-8150015/
Webrev: http://cr.openjdk.java.net/~rehn/8150015/v1/webrev/
I think this is fine but I just wanted to mention an alternative
approach. For the GC logging I introduced a GCTraceTimerImpl class and a
GCTraceTime macro. See:
http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/4030d7f9946d/src/share/vm/gc/shared/gcTraceTime.inline.hpp#l146
If you do something similar the code on the call site would look like
this:
TraceTime(Info, safepointcleanup) timer("deflating idle monitors");
instead of this:
TraceTime timer("deflating idle monitors", TRACETIME_LOG(Info,
safepointcleanup));
Your call. I just wanted to mention it.
As discussed in other forums, I have created:
https://bugs.openjdk.java.net/browse/JDK-8152089
for this.
As we also agreed on, I'll be pushing this change-set.
Thanks,
/Robbin
Thanks,
Bengt
Tested with jprt hotspot and manually tested log output.
Thanks!
/Robbin
