Alan,
This is for sanity check:
The updated hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.hs2/
Please, note that the *src/share/vm/prims/jvmtiEnvBase.hpp* was
corrected too.
Please, find the JVMTI spec here:
http:://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.hs2/jvmti.html
Thanks,
Serguei
On 4/14/16 06:53, Alan Bateman wrote:
On 14/04/2016 09:24, [email protected] wrote:
Please, review the Jigsaw-related fix for:
https://bugs.openjdk.java.net/browse/JDK-8153749
Hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.hs1/
Jdk webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8153749-Jigsaw-newcap.jdk1/
This looks good, just a few suggests for the JVM TI spec
For can_generate_early_class_hook_events then it might be better if
the first sentence said "in the primordial phase" rather than "early".
In CFLH then alternative wording is "When
can_generate_early_class_hook_events and
can_generate_early_class_hook_events are enabled then this event
may be send before the VM is initialized (the start phase)". I think
that might be more consistent with the long standing wording.
-Alan.
