Looks good! Thanks, /Staffan
> On 12 apr. 2016, at 18:05, Andreas Eriksson <andreas.eriks...@oracle.com> > wrote: > > Hi, > > Please review this fix for 8153641: assert(thread_state == _thread_in_native) > failed: Assumed thread_in_native while heap dump > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153641 > <https://bugs.openjdk.java.net/browse/JDK-8153641> > Webrev: http://cr.openjdk.java.net/~aeriksso/8153641/webrev.00/ > <http://cr.openjdk.java.net/~aeriksso/8153641/webrev.00/> > > The crash is because changes I did in JDK-8129419 > <https://bugs.openjdk.java.net/browse/JDK-8129419> do not work with solaris > logic used for UseVMInterruptibleIO in some cases. > This change reverts the changes I did to the solaris version of os::write, > and changes heapDumper.cpp to use ::write and ::close directly, as it did > before. > > Thanks, > Andreas
