On 2016-04-21 18:46, Erik Gahlin wrote:
On 2016-04-21 15:47, Andreas Eriksson wrote:
Hi,
On 2016-04-15 20:21, Erik Gahlin wrote:
Looks good, not a Reviewer.
Thanks.
Do you really need curly braces in the switch clauses?
In JavaValueArray.java they were needed before my change but not
after. Do you want me to remove them?
In JavaObject.java they are needed because the 'value' variable is a
different type in each clause, I could refactor so that I could
remove the curly braces, but I don't think it is worth the effort.
I was thinking about JavaValueArray.java.
It would look better without them, but no need to create an updated
webrev just for that.
Alright, I'll change that before I push.
Could a Reviewer take a look as well?
- Andreas
Erik
- Andreas
Erik
On 2016-04-15 16:40, Andreas Eriksson wrote:
Hi,
Please review this test fix for 8149790: NegativeArraySizeException
with hprof
https://bugs.openjdk.java.net/browse/JDK-8149790
http://cr.openjdk.java.net/~aeriksso/8149790/webrev.00/
Changes are to the hprof verifier, which now will pass heap dump
content around as JavaThing arrays instead of byte arrays, since
the latter cannot be guaranteed to be able to hold all the elements
of large arrays.
There is still a problem where the test will timeout on machines
with lots of memory (seen on machines with 200+GB of memory)
because the verification takes a long time. I'll file a new bug for
that problem.
Regards,
Andreas
