Hello,

The issue was not reproducible with or without,

"-XX:+ExplicitGCInvokesConcurrent"

Flag. The patch ensures that GC happens before we start measuring memory. Without the patch, GC might or might not happen.

-Harsha

On Friday 22 April 2016 07:58 PM, Jaroslav Bachorik wrote:
Hi,

On Fri, Apr 22, 2016 at 9:10 AM, Harsha Wardhana B <harsha.wardhan...@oracle.com <mailto:harsha.wardhan...@oracle.com>> wrote:

    Hi,

    Please review the below simple fix for issue,

    issue : https://bugs.openjdk.java.net/browse/JDK-8154166
    webrev : http://cr.openjdk.java.net/~hb/8154166/webrev.00/
    <http://cr.openjdk.java.net/%7Ehb/8154166/webrev.00/>


Shouldn't this test rather declare the conditions when it is supposed to work? According to the issue this was caused by introducing the "-XX:+ExplicitGCInvokesConcurrent" which makes it very tricky to make any assumptions about the GC process.

See eg. jdk/tests/java/lang/management/MemoryMXBean/LowMemoryTest.java for enabling the test only for allowed configurations.

Cheers,

-JB-



    -Harsha



Reply via email to