On 25 Apr 2016, at 12:50, Dmitry Samersoff <[email protected]> wrote:
> Everybody, > > Please review the changes. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8154258/webrev.04/ Thank you Dmitry. Your changes look good to me. As a follow up, it would be nice to refactor the current testlibrary so that the Unsafe dependency is put into its own testlibrary. I suspect that many of the @modules could then be removed from many tests that don’t actually depend on Unsafe. Anyway, that can some later. -Chris. > 1. Change hotspot/test/testlibrary/jdk/test/lib/Utils.java to match > <root>/test/lib/share/classes/jdk/test/lib/Utils.java > i.e. replace sun.misc.Unsafe to jdk.internal.misc.Unsafe > > 2. Add the tag > @modules java.base/jdk.internal.misc > to all tests that uses testlibrary > > 3. Replace all occurrence of sun.misc.Unsafe to jdk.internal.misc.Unsafe > > Testing: local, RBT:hotspot_all > > -Dmitry > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources.
