> On May 5, 2016, at 5:51 AM, Dmitry Samersoff <dmitry.samers...@oracle.com> > wrote: > > Please, see updated webrev. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/ToolProvider.java I suggest to remove this as jdk.hotspot.agent is no longer a provider. You could keep the getName and run methods and just remove @Override annotation. I only skimmed on the jdk change. test/sun/tools/jinfo/BasicJInfoTest.java It has @bug 6260070 (an old bug). Is it renamed from an existing test? OR just cut-n-paste error. 35 * @modules java.management Is this still needed? test/sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java and other jhsdb tests should have @modules jdk.hotspot.agent Mandy