Yasumasa, The changes looks good. I'll sponsor the push.
1. I would prefer to check arguments explicitly for better readability: if (!requestHeapDump && dumpfile != null) { throw IAE("Unexpected argument dumpfile"); } 2. Please update jdk/test/sun/tools/jhsdb/BasicLauncherTest.java -Dmitry On 2016-05-04 17:47, Yasumasa Suenaga wrote: > Hi all, > > This review request relates to [1]. > > We cannot change heapdump name (heap.bin) when we genarate heapdump via > jhsdb. > > When we use jmap, we can change heapdump name through file option. > I want to set it like a jmap. > > I uploaded webrev for this enhancement. > Could you review it? > > http://cr.openjdk.java.net/~ysuenaga/JDK-8156033/webrev.00/ > > I cannot access JPRT. > So I need a sponsor. > > > Thanks, > > Yasumasa > > > [1] > http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-April/019510.html > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.