On 13/07/2016 9:06 PM, Mandy Chung wrote:
On Jul 13, 2016, at 6:56 PM, Amit Sapre <amit.sa...@oracle.com> wrote:
Hello,
Please review the fix
Bug ID : https://bugs.openjdk.java.net/browse/JDK-8151099
Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8151099/webrev.00/
Looks okay.
You could rename the method to load_and_initialize_klass_or_null to follow the
existing naming convention.
+1 on that "softload" is not suitable.
My concern is that the code that calls
Management::com_sun_management_internal_GarbageCollectorExtImpl_klass
does not seem to handle getting NULL correctly:
./share/vm/services/memoryManager.cpp
./share/vm/services/gcNotifier.cpp
Thanks,
David
-----
This patch needs to include the test attached in the bug report.
Mandy
