On 20/09/2016 11:33, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8147943
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8147943-jvmti-header.hs1/
Summary:
The problem is that the
build/*/hotspot/variant-server/gensrc/jvmvtifiles/jvmti.h
is currently generated with the GPL copyright comment.
The JDK version of the header that we ship must havethe GPL +
"Classpath" exception.
So that the file is taken from the version that is checked into the
jdk repository:
jdk/src/java.base/share/native/include/jvmti.h.
The patch looks okay to me but I just wonder if it would be worth trying
to consume license template from <top>/make/templates rather than having
it in jvmtiLib.xsl - you may have looked at this ready and discounted it.
-Alan