Thanks Vladimir for taking a look, I have done some minor updates to the webrev:
Webrev: http://cr.openjdk.java.net/~mgronlun/8166806/webrev02/ Bug: http://bugs.openjdk.java.net/browse/JDK-8166806 The associated closed changes have been sent internally. Thanks Markus -----Original Message----- From: Vladimir Kozlov Sent: den 28 september 2016 20:01 To: Markus Gronlund; [email protected]; [email protected]; Nils Eliasson Subject: Re: RFR(XS): 8166806: Add intrinsic support for writer used in event based tracing Hi Markus, Where _getBufferWriter is defined? I don't see closed changes. c1_LIRGenerator.cpp: should you use oopConst(NULL) in compare? library_call.cpp: TypeInstPtr::MIRROR is useless since the result phi type is TypePtr::BOTTOM. Using TypePtr::BOTTOM for load could be less bug prone. Thanks, Vladimir On 9/27/16 1:58 PM, Markus Gronlund wrote: > Greetings, > > > > Kindly asking for reviews for the following change: > > > > Bug: http://bugs.openjdk.java.net/browse/JDK-8166806 > > Webrev: http://cr.openjdk.java.net/~mgronlun/8166806/webrev/ > > > > Thanks in advance > > Markus >
