Hi, Please find the updated webrev with suggested changes Webrev - http://cr.openjdk.java.net/~rpatil/8173664/webrev.01/ BugID: https://bugs.openjdk.java.net/browse/JDK-8173664
Thanks, Fairoz > -----Original Message----- > From: Fairoz Matte > Sent: Thursday, May 11, 2017 9:05 AM > To: David Holmes <david.hol...@oracle.com>; serviceability- > d...@openjdk.java.net > Subject: RE: RFR: JDK-8173664: Typo in https://java.net/downloads/heap- > snapshot/hprof-binary-format.html > > Hi David, > > After having discussion with you over IM things are clear Expected change is - > "There will be a "LOAD CLASS" tag for the type of each array in the dump" > and current changeset missed "the" before type. > > I will make the changes and send it again. > > Thanks, > Fairoz > > > -----Original Message----- > > From: David Holmes > > Sent: Thursday, May 11, 2017 7:52 AM > > To: Fairoz Matte <fairoz.ma...@oracle.com>; serviceability- > > d...@openjdk.java.net > > Subject: Re: RFR: JDK-8173664: Typo in > > https://java.net/downloads/heap- snapshot/hprof-binary-format.html > > > > On 10/05/2017 9:30 PM, Fairoz Matte wrote: > > > Hi David, > > > > > >> -----Original Message----- > > >> From: David Holmes > > >> Sent: Wednesday, May 10, 2017 3:26 PM > > >> To: Fairoz Matte <fairoz.ma...@oracle.com>; serviceability- > > >> d...@openjdk.java.net > > >> Subject: Re: RFR: JDK-8173664: Typo in > > >> https://java.net/downloads/heap- snapshot/hprof-binary-format.html > > >> > > >> Hi Fairoz, > > >> > > >> On 10/05/2017 5:53 PM, Fairoz Matte wrote: > > >>> Hi, > > >>> > > >>> Kindly review the small typo fix, applicable only for JDK8 > > >>> BugID: https://bugs.openjdk.java.net/browse/JDK-8173664 > > >>> Webrev: http://cr.openjdk.java.net/~rpatil/8173664/webrev/ > > >> > > >> I think "for type type" was intended to be "for the type". > > >> > > > Yes it does look like after reading multiple times. > > > Thanks for the review I will close as Not an issue > > > > ??? It is still a typo that can be fixed. > > > > David > > > > > Thanks, > > > Fairoz > > > > > >> David > > >> > > >>> Thanks, > > >>> Fairoz > > >>>
