Hi Alan,
Thank you for the comments!
I've made a stand-alone IsModifiableModule test and also added "@modules
jdk.jdi" to the GetNamedModuleTest.
New webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8178054-jvmti-ismodif.3/
Thanks,
Serguei
On 6/9/17 00:44, Alan Bateman wrote:
On 09/06/2017 01:10, serguei.spit...@oracle.com wrote:
Please, review a JDK 9 fix for the test enhancement:
https://bugs.openjdk.java.net/browse/JDK-8178054
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8178054-jvmti-ismodif.2/
Summary:
New JVMTI function IsModifiableModule() was introduced a couple of
month ago.
This patch adds a test coverage for it.
This update means that GetNamedModuleTest now tests both
GetNamedModule and IsModifiableModule. Would be better to separate
them so that there are two focused tests rather than one test trying
to test two functions? If it has to be one test then I assume
GetNamedModuleTest and the description in @summary will need to be
updated.
Otherwise the test coverage looks good as it exercises both named and
unnamed modules, plus it tests the error cases.
In passing, it looks like "@modules jdk.jdi" is missing (pre-dates
your changes).
-Alan
