> On Jun 14, 2017, at 12:58 PM, Poonam Parhar <poonam.ba...@oracle.com> wrote:
> 
> 
> [Poonam] yes, that could also be another way. But for this bug, I would like 
> to keep the changes in sync with how the exceptions in the Java code called 
> from the VM side of the Service Thread are handled. For example, 
> ServiceThread::service_thread_entry() also calls 
> GCNotifier::sendNotification() and here’s how the pending exception is 
> handled.
>  
>  
> 


You can still keep the clear pending exception.   The main thing I suggest is 
to change the trigger method to take the raw long value parameters instead of 
MemoryUsage and the object allocation is all done in Java.

>  :
>  
> When we get to the issue of enabling the debugging of the user code currently 
> being executed on the ServiceThread, we will have to be looking at these 
> other notifications as well and I would prefer that we make those changes 
> together under the same bug and not with this change.
>  
> Please let me know what you think.
> 

I’m okay if you want to resolve this issue as is.  And follow up my feedback 
together with the other issue with ServiceThread.

Mandy

Reply via email to