Hi Goetz,

On 24/08/2017 6:15 PM, Lindenmaier, Goetz wrote:
Hi,

Could I please get a review for this small fix to the tests?
http://cr.openjdk.java.net/~goetz/wr17/8186719-cdsRequires/webrev.01/

I introduces property @requires vm.cds in the hotspot test suite, and
now identified three tests in the jdk suite that require the same.

Should JDK-8185436 have made the changes to TEST.ROOT? I don't understand all the changes that have been added there. Did JDK-8185436 make VMProps.java dependent on WhitBox API but not provide a means to actually build VMProps properly??

I think the TEST.ROOT change may need wider review than serviceability-dev.

Thanks,
David

Best regards,
  Goetz.

Reply via email to