On 27/09/2017 8:52 AM, serguei.spit...@oracle.com wrote:
Hi David,
On 9/26/17 15:09, David Holmes wrote:
Hi Sergeui,
On 27/09/2017 3:51 AM, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
On 9/26/17 02:41, Yasumasa Suenaga wrote:
Hi Serguei,
Thank you for your comment!
This fix looks Ok to me but you need to add a unit test.
I guess it is caused by inlined method which is generated by JIT
compiler. I don't know how to reproduce it on jtreg test.
Do you have any idea for it?
I'm not sure what exact problem you have with jtreg.
You may want to try to use other jtreg tests as examples.
I see two problems:
1. hsdb is an interactive GUI tool
There is already at least one jtreg hsdb test:
open/test/hotspot/jtreg/serviceability/sa/JhsdbThreadInfoTest.java
Not sure, if this example would help in this case though.
2. The problem seems related to JIT inlining - so how do you force
that in a test?
Then I wonder how was it forced in the manual reproducer?
The fact it is fixed has to be verified anyway.
Well the reproducer happens to hit the issue, so we can use it to
manually verify.
I would think this is a noreg-hard situation. As long as there is a
manual reproducer that can be used to verify the fix - as per the bug
report - that should be okay IMHO.
I'm Ok with adding noreg-hard label if it is hard to develop.
Sounds good to me. The manual verification steps should be very clearly
spelt out in the bug report so that even someone unfamiliar with hsdb
(like me!) can follow them easily.
Cheers,
David
Thanks,
Serguei
Cheers,
David
Thanks,
Serguei
Yasumasa
2017-09-26 18:15 GMT+09:00 serguei.spit...@oracle.com
<serguei.spit...@oracle.com>:
Hi Yasumasa,
This fix looks Ok to me but you need to add a unit test.
Thanks,
Serguei
On 9/20/17 15:47, Yasumasa Suenaga wrote:
PING:
Have you checked this issue?
http://cr.openjdk.java.net/~ysuenaga/JDK-8187401/webrev.00/
Yasumasa
On 2017/09/11 11:16, Yasumasa Suenaga wrote:
Hi all,
This review request is a part of [1].
JBS:
https://bugs.openjdk.java.net/browse/JDK-8187401
webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8187401/webrev.00/
I cannot access JPRT. So I need a sponsor.
Thanks,
Yasumasa
[1]
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021821.html
