On 10/10/17 4:47 AM, Ujwal Vangapally wrote:
Kindly review the changes made.

https://bugs.openjdk.java.net/browse/JDK-8044122

webrev : http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.00/


RuntimeMXBean.java
   @since is missing

   Process::pid is long rather than int. The javadoc for this method should be consistent with Process::pid, as Alan points out.

VMManagementImpl.java
    I think getProcessId should probably be replaced to implement with ProcessHandle.current().pid();

Please include an unit test for it.

Mandy

Reply via email to