Hi Alan, thanks for looking at my change.
Thanks for pointing to JEP 293. I see my change mostly follows its ideas. As Jon, I don't think asking for support of -help makes sense as it's not according to the gnu style, and it's not that hard to get it right anyways. I'll remove the edits to the properties files. The deprecated tools are orbd, wsgen wsimport schemagen Is that correct? I'll remove them from my change. The test has a list of tools not to test, I'll add them there. Best regards, Goetz. > -----Original Message----- > From: Alan Bateman [mailto:alan.bate...@oracle.com] > Sent: Samstag, 18. November 2017 09:42 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; core-libs- > d...@openjdk.java.net; 'compiler-...@openjdk.java.net' <compiler- > d...@openjdk.java.net>; serviceability-dev (serviceability- > d...@openjdk.java.net) <serviceability-dev@openjdk.java.net> > Subject: Re: RFR: 8189102: All tools should support -?, -h and --help > > On 17/11/2017 11:23, Lindenmaier, Goetz wrote: > > Hi, > > > > please review this change. I also filed a CSR for this: > > http://cr.openjdk.java.net/~goetz/wr17/8189102- > helpMessage/webrev.02/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8189102 > > CSR: https://bugs.openjdk.java.net/browse/JDK-8191477 > > > > See the webrev for a detailed description of the changes. > > > A question for Jon Gibbons: In JEP 293 the guideline is that tools > should support `--help`. Do you think this should be expanded to include > `-help`, and `-?` (and maybe `-h` where it make sense)? > > As regards the webrev then the changes to the localized resources can be > dropped. As Jon noted, we don't usually edit these directly as they are > bulk updated/replaced by translation drops that usually happen late in > each release. > > It's not clear to me that it's wroth trying to update the JAXB, JAX-WS, > and CORBA tools. One reason the corresponding tool modules are > deprecated-for-removal and there is a draft JEP to remove them > completely [1]. In addition, the JAXB ad JAX-WS tools are problematic to > change as they are owned by upstream projects on the Java EE github - > any changes to the code in these modules needs to coordinated to avoid > having a fork here. > > -Alan > > [1] http://openjdk.java.net/jeps/8189188
