Looks good to me.
Thanks,
Jini.
On 11/29/2017 3:06 PM, Sharath Ballal wrote:
Thanks Jini. Updated webrev is at
http://cr.openjdk.java.net/~sballal/8184982/webrev.02/
Thanks,
Sharath
-----Original Message-----
From: Jini George
Sent: Wednesday, November 29, 2017 2:04 PM
To: Sharath Ballal; [email protected]
Subject: Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java
program generates NullPointerException
Looks good to me, Sharath. Just a nit. In the following file:
http://cr.openjdk.java.net/~sballal/8184982/webrev.01/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/PackageNameFilter.java.sdiff.html
The check for the package list being null can be done before populating
klassName with the replaced '/'s.
Thanks,
Jini (Not a Reviewer).
On 11/28/2017 11:45 AM, Sharath Ballal wrote:
> Can I get one more review please ?
>
> Thanks,
>
> Sharath
>
> *From:*Sharath Ballal
> *Sent:* Wednesday, November 22, 2017 2:53 PM
> *To:* Sundararajan Athijegannathan;
> [email protected]
<mailto:[email protected]>
> *Subject:* RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple
> java program generates NullPointerException
>
> Thanks Sundar.
>
> Thanks,
>
> Sharath
>
> *From:*Sundararajan Athijegannathan
> *Sent:* Tuesday, November 21, 2017 7:38 PM
> *To:* [email protected]
<mailto:[email protected]>
> <mailto:[email protected]>
> *Subject:* Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple
> java program generates NullPointerException
>
> +1
>
> -Sundar
>
> On 21/11/17, 3:26 PM, Sharath Ballal wrote:
>
> I have made minor modification to the test (added @bug and removed
> @modules).
>
> The revised webrev is
>
> http://cr.openjdk.java.net/~sballal/8184982/webrev.01/
> <http://cr.openjdk.java.net/%7Esballal/8184982/webrev.01/>
>
> Thanks,
>
> Sharath
>
> *From:* Sharath Ballal
> *Sent:* Tuesday, November 21, 2017 12:27 PM
> *To:* [email protected]
<mailto:[email protected]>
> <mailto:[email protected]>
> *Subject:* RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple
> java program generates NullPointerException
>
> Gentle reminder.
>
> Thanks,
>
> Sharath
>
> *From:* Sharath Ballal
> *Sent:* Tuesday, November 14, 2017 10:31 AM
> *To:* [email protected]
<mailto:[email protected]>
> <mailto:[email protected]>
> *Subject:* RFR: JDK-8184982 - SA: Running ClassDump on a simple java
> program generates NullPointerException
>
> Hello,
>
> Pls review the code changes and testcase for the following issue.
>
> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8184982
>
> Webrev: http://cr.openjdk.java.net/~sballal/8184982/webrev.00/
> <http://cr.openjdk.java.net/%7Esballal/8184982/webrev.00/>
>
> Thanks,
>
> Sharath
>
