On 12/7/17 10:08, serguei.spit...@oracle.com wrote:
Hi Dan,

The fix looks good to me.
Nice, you have caught it.

Do you want this fixed in 10 or 11?
I thought that the jdk/hs is for 11 now.
Is it correct?

Never mind.
I've just found a message from Jesper the jdk/hs is used for 10 pushes for one more week.

Thanks,
Serguei


Thanks,
Serguei


On 12/7/17 09:09, Daniel D. Daugherty wrote:
Roger,

Thanks for the review!

Dan

P.S.
I'm planning to push this fix to jdk/hs since the only sightings
have been in jdk/hs testing or in projects that are parented to
jdk/hs repos... Hope that's okay...


On 12/7/17 12:07 PM, Roger Riggs wrote:
+1

On 12/7/2017 12:00 PM, Gerald Thornbrugh wrote:
Hi Dan,

Your fix looks good.

Jerry

Adding core-libs-dev@... since this is RMI code. Thanks Alan!

Folks, this review spans three OpenJDK aliases so Thunderbird's
reply-to-list feature won't get it right. This is one of the
few times that reply-to-all is the right thing to do...

Dan

On 12/7/17 11:38 AM, Daniel D. Daugherty wrote:
Greetings,

I have a small fix for a very intermittent ServerSocket related test
failure:

    JDK-8182307: Error during JRMP connection establishment
https://bugs.openjdk.java.net/browse/JDK-8182307

The fix is copied from Jerry's work on the following bugs:

    JDK-8182757 JDWP: Socket Transport handshake hangs on Solaris
https://bugs.openjdk.java.net/browse/JDK-8182757

    JDK-8178676 nsk/jvmti/AttachOnDemand/attach045 fails with Exception
https://bugs.openjdk.java.net/browse/JDK-8178676

For the gory details of the reasons for this fix please see
Jerry's bugs.

Webrev URL: http://cr.openjdk.java.net/~dcubed/8182307-webrev/jdk10-0/


I observed this test failure one time in my Thread-SMR work and have
been including this fix in months of Thread-SMR stress testing. It was also included in both JPRT and Mach5 tier[1-5] testing of the Thread-SMR
changes.

Thanks, in advance, for any comments, suggestions or questions.

Dan







Reply via email to