Hi, I had to update my webrev after the javah launcher had been removed: http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.07/
I would appreciate a final decision to push this. Best regards, Goetz. -----Original Message----- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Lindenmaier, Goetz Sent: Tuesday, December 12, 2017 11:37 AM To: Alan Bateman <alan.bate...@oracle.com>; core-libs-...@openjdk.java.net; 'compiler-...@openjdk.java.net' <compiler-...@openjdk.java.net>; serviceability-dev (serviceability-dev@openjdk.java.net) <serviceability-dev@openjdk.java.net> Subject: RE: FW: RFR(M): 8189102: All tools should support -?, -h and --help Hi Alan, Javadoc combines documentation and support of a flag in the way the flag handling is implemented. On the other side, it prints the help message anyways if a wrong flag is presented to it, so if you call it with -help you get the help message. Therefore, in my original change where I tried to get it more cleaned up, I removed -help support and documentation from Javadoc. I added it again and updated the table in the CSR: http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.06/ Best regards, Goetz. > -----Original Message----- > From: Alan Bateman [mailto:alan.bate...@oracle.com] > Sent: Montag, 11. Dezember 2017 17:53 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; core-libs- > d...@openjdk.java.net; 'compiler-...@openjdk.java.net' <compiler- > d...@openjdk.java.net>; serviceability-dev (serviceability- > d...@openjdk.java.net) <serviceability-dev@openjdk.java.net> > Subject: Re: FW: RFR(M): 8189102: All tools should support -?, -h and --help > > > > On 07/12/2017 11:20, Lindenmaier, Goetz wrote: > > Hi, > > > > ... missed some lists in my first post ... > > > > I prepared a fifth webrev for this change. Please review. > > > > It incorporates the changes requested by the CSR reviewers > > (not to remove docuemtation of '-help' where is was documented > > before) and the changes proposed by Kumar: > > http://cr.openjdk.java.net/~goetz/wr17/8189102- > helpMessage/webrev.05/ > > > > > Looks like it still drops -help from the javadoc usage message, I can't > tell if you meant to do that. > > -Alan.
