Hi Gary,
Overall looks good. There's one minor change you might wanted to
consider. It's possible the library failed to load for reasons other
than java.instrument not being included. I see the error output already
includes the error message from the failed dll_open() call, so why not
just suggest that it *may* be due to java.instrument missing rather than
implying that is known to be the reason why.
thanks,
Chris
On 12/18/17 6:38 AM, Gary Adams wrote:
Here's a simple fix to include additional information when the
instrument library is
missing from the jre and the command line requests -javaagent.
Issue: https://bugs.openjdk.java.net/browse/JDK-8180709
Webrev: http://cr.openjdk.java.net/~gadams/8180709/webrev.00/
