Hi Leo, Looks good, thanks for doing this.
Sorry for the delay. Cheers Markus -----Original Message----- From: Leo Korinth Sent: den 13 februari 2018 12:26 To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8196337 Add commit methods that take all event properties as argument Hi, I would be happy for reviews! Thanks, Leo On 31/01/18 11:00, Leo Korinth wrote: > Hi, > > I am adding commit methods that take all event properties as argument. > > For instant events (without start and stop times) a static commit > method is created (taking all properties). > > For non-instant events, a non static commit method is created (taking > all properties). Also a static commit method (with additional > startTicks/endTicks) is created. > > Also an extra constructor is created (taking all properties). An auto > commit destructor was considered (that would auto commit if the > constructor with all properties was used) but has not yet been implemented. > > Enhancement: > https://bugs.openjdk.java.net/browse/JDK-8196337 > > Webrev: > http://cr.openjdk.java.net/~lkorinth/8196337/00/ (open) > > Testing: > - hs-tier1, hs-tier2 > > Thanks, > Leo