Makes sense to me. Looks good.

/Erik


On 2018-04-23 05:01, Baesken, Matthias wrote:

Hello,   as far as I know  the serviceability agent   is not  supported on  linux s390x .

However  (unlike  on aix where it is not supported as well) ,   INCLUDE_SA=false is not set  in the central configure  m4 files .

Should we set it  ( suggested diff below)  ?

Best regards, Matthias

hg diff

diff -r fcd5df7aa235 make/autoconf/jdk-options.m4

--- a/make/autoconf/jdk-options.m4      Wed Apr 18 11:19:32 2018 +0200

+++ b/make/autoconf/jdk-options.m4      Mon Apr 23 13:46:17 2018 +0200

@@ -238,6 +238,9 @@

   if test "x$OPENJDK_TARGET_OS" = xaix ; then

     INCLUDE_SA=false

   fi

+  if test "x$OPENJDK_TARGET_CPU" = xs390x ; then

+    INCLUDE_SA=false

+  fi

   AC_SUBST(INCLUDE_SA)

# Compress jars

Best regards, Matthias


Reply via email to