+1
Thanks,
Serguei
On 5/11/18 06:52, Mikhailo Seledtsov wrote:
Looks good to me,
Misha
On 5/9/18, 5:14 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8202392/webrev.00/index.html
1396 lines changed: 1396 ins; 0 del; 0 mod;
Hi all,
could you please review his patch which open sources heapdump tests
from so-called VM testbase? as it's obvious from test names, they
test heap dumping using jmap and a number of JVM flags.
As usually w/ VM testbase code, these tests are old, they have been
run in hotspot testing for a long period of time. Originally, these
tests were run by a test harness different from jtreg and had
different build and execution schemes, some parts couldn't be easily
translated to jtreg, so tests might have actions or pieces of code
which look weird. In a long term, we are planning to rework them.
webrev:
http://cr.openjdk.java.net/~iignatyev//8202392/webrev.00/index.html
JBS: https://bugs.openjdk.java.net/browse/JDK-8202392
testing: :vmTestbase_vm_heapdump test group
Thanks,
-- Igor
