+1 Thanks for fixing it!
Jiangli > On May 30, 2018, at 4:29 PM, Ioi Lam <ioi....@oracle.com> wrote: > > Hi Alex, > > The changes look good. Thank you so much for fixing it. > > - Ioi > > >> On 5/30/18 3:57 PM, serguei.spit...@oracle.com wrote: >> Hi Alex, >> >> The fix looks good to me. >> >> It'd be nice if someone from the CDS/App-CDS experts looked at this. >> I've extended the mailing list. >> >> Thanks, >> Serguei >> >> >>> On 5/30/18 11:52, Alex Menkov wrote: >>> Hi all, >>> >>> Please review a fix for >>> bug: https://bugs.openjdk.java.net/browse/JDK-8203031 >>> fix: http://cr.openjdk.java.net/~amenkov/addToBootstrapCLSearch/webrev/ >>> >>> The issue is a regression from JDK-8193213 (Make the UseAppCDS option >>> obsolete) >>> >>> FileMapInfo::current_info() is initialized by FileMapInfo ctor only when >>> UseSharedSpaces == true: >>> Metaspace::global_initialize() >>> -> MetaspaceShared::initialize_runtime_shared_and_meta_spaces >>> -> new FileMapInfo() >>> >>> --alex >> >
