On 30/05/2018 16:50, Sharath Ballal wrote:
Hello,
Requesting reviews for Usage Logger open sourcing (earlier known as
Usage Tracker).
ID: https://bugs.openjdk.java.net/browse/JDK-8199729
Webrev: http://cr.openjdk.java.net/~sballal/8199729/webrev.00/
<http://cr.openjdk.java.net/%7Esballal/8199729/webrev.00/>
I skimmed through this. I think the implementation will need significant
clean-up before it is ready for code review. Also it feels like this
feature needs more a lot context to understand how the data is consumed
and whether the log files and UDP messages are intended to be a
supported interface or not.
The use of system wide locations for configuration files is something
that needs discussion as it's not clear (to me anyway) if the locations
chosen are appropriate in all cases.
In terms of code organization then I assume the code to check for
usagelogger.properties should not be in PostVMInitHook, it should be
moved to UserLoggerClient. Also there seems to be a dependency on
EnvUtils that is not in the webrev. The package name for this code will
also need discussion, I assume it needs to be moved to jdk.internal.
-Alan
