Hi Thomas,
On 7/06/2018 2:36 PM, Thomas Stüfe wrote:
Ping...
may I please have a second review?
Seems fine in terms of overall code structure etc. I can't comment on
the output produced as such. :)
Some minor code-style nits (just to prove I read it):
- inconsistent placement of opening { in method definitions: should
always be after the end of the parameter list ie ....) {
- inconsistent variable naming wrt. use of underscores: maxdepth ->
max_depth?, twiglen -> twig_len, branchtracker -> branch_tracker?
No need to see any update.
Thanks,
David
For your convenience, the latest webrev with Coleen's requests worked in is:
http://cr.openjdk.java.net/~stuefe/webrevs/8203682-jcmd-print-classloader-hierarchy/webrev.01/webrev/
JBS issue: https://bugs.openjdk.java.net/browse/JDK-8203682
Thank you very much.
Best Regards, Thomas
On Wed, May 23, 2018 at 2:46 PM, Thomas Stüfe <[email protected]> wrote:
Dear all,
(not sure if this would be a serviceability or runtime rfe, so sorry
for crossposting)
may I please have feedback/reviews for this small enhancement.
Bug: https://bugs.openjdk.java.net/browse/JDK-8203682
Webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8203682-jcmd-print-classloader-hierarchy/webrev.00/webrev/
This adds a new command to jcmd, "VM.classloaders". It complements the
existing command "VM.classloader_stats".
This command, in its simplest form, prints the class loader tree. In
addition to that, it optionally prints out loaded classes (both
non-anonymous and anonymous) and various classloader specific
information.
Examples:
http://cr.openjdk.java.net/~stuefe/webrevs/8203682-jcmd-print-classloader-hierarchy/example.txt
http://cr.openjdk.java.net/~stuefe/webrevs/8203682-jcmd-print-classloader-hierarchy/example-with-classes.txt
http://cr.openjdk.java.net/~stuefe/webrevs/8203682-jcmd-print-classloader-hierarchy/example-with-reflection-and-noinflation.txt
Thanks and Best Regards,
Thomas
