Hi Jini, Changes in MacosxDebuggerLocal.m looks good.
Thanks, Sharath -----Original Message----- From: Jini George Sent: Sunday, June 24, 2018 11:07 PM To: Erik Joelsson; serviceability-dev@openjdk.java.net; build-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC Hi Erik, Thank you very much for looking into this. I have addressed your comments. The latest webrev is at: http://cr.openjdk.java.net/~jgeorge/8189429/webrev.06/ Thank you, Jini. On 6/23/2018 3:31 AM, Erik Joelsson wrote: > Hello Jini, > > In general this looks pretty good, but it's also breaking some new > ground as it's adding generation of native source in the java gensrc > step. Mixing native code with the java code that the genrcs targets > and gensrc output directories are meant for seems ok for now, but may > cause trouble in the future. I'm going to accept it for now though. > > In Gensrc-jdk.hotspot.agent.gmk: Please put the new macosx stuff in > its own section (as delimited by the 80x # lines) and put that whole > thing inside a conditional for macosx. Also please break line 47 (for > recipe lines, indent with tab and 4 additional spaces for continuation [1]). > > In Lib-jdk.hotspot.agent.gmk: I believe adding extra src should be > enough as that will implicitly add the same directories as header dirs > by default. At least that's the intention. > > /Erik > > [1] http://openjdk.java.net/groups/build/doc/code-conventions.html > > On 2018-06-22 11:11, Jini George wrote: >> Hi all, >> >> [Including build-dev also since this includes build related changes]. >> >> Requesting reviews for: >> >> https://bugs.openjdk.java.net/browse/JDK-8189429 (SA: MacOSX: Replace >> the deprecated PT_ATTACH with PT_ATTACHEXC) >> >> Webrev: http://cr.openjdk.java.net/~jgeorge/8189429/webrev.04/ >> >> This is the follow-up solution for the temporary restoration of >> PT_ATTACH to fix https://bugs.openjdk.java.net/browse/JDK-8184042 >> (several serviceability/sa tests timed out on MacOS X), which was >> done in Oct 2017. The mails related to this are at: >> >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-August >> /021702.html >> >> >> Changes as compared to the patch sent last year >> (http://cr.openjdk.java.net/~jgeorge/8184042/webrev.00/): >> >> * Addressed the review comments which were provided by Poonam, Dan, >> Dmitry. >> * A major change as compared to what was done last year is that the >> MIG generated files have been included as a part of the JDK build >> process. >> * The test case which was provided in the patch last year is no >> longer required since we have ClhsdbAttach.java testing the same >> functionality as a part of the SA testsuite now. >> * Other than that, some minor improvements have been done wrt error >> handling. >> >> The steps for the proposed solution have been provided in JBS. >> >> Testing: ALL the SA tests pass on MacOSX and the other Mach5 platforms. >> >> Thanks to Sharath, Robin, Gerard and Dan for looking into the changes >> and providing valuable comments. >> >> Thanks, >> Jini. >
