Thanks Dan.
Thanks, Sharath -----Original Message----- From: Daniel D. Daugherty Sent: Friday, August 17, 2018 8:09 PM To: Sharath Ballal; Jini Susan George; serviceability-dev@openjdk.java.net Subject: Re: RFR: xs: JDK-8209342 - Problemlist SA tests on Solaris due to Error attaching to process: Can't create thread_db agent! On 8/17/18 6:25 AM, Sharath Ballal wrote: > Thanks for the comments Jini. I have added > serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java, > serviceability/sa/ClhsdbCDSCore.java and > test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java. > > I have not deleted the following tests as these changes will get propagated > to 11 as well. > >> serviceability/sa/ClhsdbSymbol.java 8193639 solaris-all >> serviceability/sa/ClhsdbSymbolTable.java 8193639 solaris-all > http://cr.openjdk.java.net/~sballal/8209342/webrev.01/ test/hotspot/jtreg/ProblemList.txt All of these entries are good for JDK11 and JDK12. test/jdk/ProblemList.txt All of these entries are good for JDK11 and JDK12. Thumbs up! Dan > > Thanks, > Sharath > > > -----Original Message----- > From: Jini George > Sent: Thursday, August 16, 2018 10:07 AM > To: Sharath Ballal; serviceability-dev@openjdk.java.net > Subject: Re: RFR: xs: JDK-8209342 - Problemlist SA tests on Solaris due to > Error attaching to process: Can't create thread_db agent! > > Hi again, Sharath, > > I missed a point. The tests serviceability/sa/ClhsdbCDSCore.java and > test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.jav > a would also have to be excluded for solaris. > > Thanks, > Jini. > > On 8/15/2018 9:46 PM, Jini George wrote: >> Hi Sharath, >> >> Your changes look good. One question: >> >> Was the following test excluded by mistake ? >> >> serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java >> >> Would you please also delete these 2 lines since these tests have >> been removed ? >> >> serviceability/sa/ClhsdbSymbol.java 8193639 solaris-all >> serviceability/sa/ClhsdbSymbolTable.java 8193639 solaris-all >> >> Thanks, >> Jini >> >> >> On 8/14/2018 12:48 PM, Sharath Ballal wrote: >>> Hello, >>> >>> Pls review this small fix to problem list SA testcases failing on >>> Solaris. >>> >>> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8209342 >>> >>> Webrev: http://cr.openjdk.java.net/~sballal/8209342/webrev.00/ >>> <http://cr.openjdk.java.net/%7Esballal/8209342/webrev.00/> >>> >>> Thanks, >>> >>> Sharath >>>