Re: RFR (M) 8212535: Remove spaces before/after () for vmTestbase/[a-s]*

[Chris Plummer]

Hi JC, iterinstcls006.cpp: Can you fix the indentation of the second line.   98             NSK_COMPLAIN2("Local storage was corrupted: %s ,\n\texpected value: %s\n",   99                              (char *)storage_ptr, storage_data); iterobjreachobj004.cpp: Can you fix the indentation of the second line.  123             NSK_COMPLAIN2("Local storage was corrupted: %s ,\n\texpected value: %s\n",  124                              (char *)storage_ptr, storage_data); iterreachobj002.cpp: You didn't align the arguments like you have elsewhere.  175 stackReferenceCallbackForSecondObjectsIteration(jvmtiHeapRootKind root_kind,  176                          jlong     class_tag,  177                          jlong     size,  178                          jlong*    tag_ptr,  179                          jlong     thread_tag,  180                          jint      depth,  181                          jmethodID method,  182                          jint      slot,  183                          void*     user_data) { iterreachobj004.cpp: Can you fix the indentation of the second line.   75         NSK_COMPLAIN2("heapRootCallback: Local storage was corrupted: %s ,\n\texpected value: %s\n",   76                          (char *)storage_ptr, storage_data);  119         NSK_COMPLAIN2("stackReferenceCallback: Local storage was corrupted: %s ,\n\texpected value: %s\n",  120                          (char *)storage_ptr, storage_data);  162         NSK_COMPLAIN2("objectReferenceCallback: Local storage was corrupted: %s ,\n\texpected value: %s\n",  163                          (char *)storage_ptr, storage_data); thanks, Chris On 10/19/18 1:49 PM, JC Beyler wrote: Hi all, Sorry about the spam; forgot to add the subject :) Here is the first of three webrevs to remove spaces around (); I also removed any space after !. When the change modified where future parameters should be indented, I changed those too (such as http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html) Webrev: http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8212535 Thanks! Jc On Fri, Oct 19, 2018 at 1:47 PM JC Beyler <jcbey...@google.com> wrote: Hi all, Here is the first of three webrevs to remove spaces around (); I also removed any space after !. When the change modified where future parameters should be indented, I changed those too (such as http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html) Webrev: https://bugs.openjdk.java.net/browse/JDK-8212535 Bug: https://bugs.openjdk.java.net/browse/JDK-8212535 Let me know what you think, Jc