Hi JC.
In Callbacks.cpp you missed the needed extra indent on the lines
following the "if":
406 if (!NSK_JVMTI_VERIFY(jvmti->GetFieldName(targetClass,
407 targetFields[field],
408 &objects_info[object].fields[field].name,
409 &objects_info[object].fields[field].signature,
410 NULL)))
481 if ((objects_info[object].fields[field].primitive &&
!objects_info[object].collected)
482 || !objects_info[object].fields[field].collected) {
Otherwise looks good. I don't need to see another webrev.
thanks,
Chris
On 11/7/18 11:20 AM, JC Beyler wrote:
Hi all,
Could I get a review for a relatively straight-forward space
transformation webrev? This adds spaces between keywords and '(' and
fixes the case "){" across C++ files in vmTestbase.
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212939/webrev.00/
<http://cr.openjdk.java.net/%7Ejcbeyler/8212939/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212939
Thanks!
Jc
