On Tue, 2018-11-13 at 10:46 +0530, Jini George wrote: > Looks good to me, Severin.
Thanks for the review! I believe I still need a review from a JDK 8u Reviewer: http://openjdk.java.net/census#jdk8u Thanks, Severin > While looking at this, I realized that the code improvement change of > 8140482 in ps_core.c of increasing the BUF_SIZE by 1 and adding the '\0' > would be needed for MacOS also -- I will file another bug for that for > JDK 12. > > Thanks! > Jini. > > On 11/9/2018 9:31 PM, Severin Gehwolf wrote: > > Hi, > > > > Could somebody please review this 8u backport of 8210836 as I'd like to > > get 8210647 (opt for sa) backported to 8u as well? Unfortunately the > > change from JDK 12 doesn't apply cleanly so I've included select > > changes from 8140482 so that the backport remains minimal. If anything, > > this makes the code more robust I'd think. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8210836 > > webrev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210836/jdk8/webrev.01/ > > > > Testing: Manual testing of loading core file in SA on linux. Stepping > > through code in the debugger. Basic jsadebugd core file loading. > > > > Thoughts? > > > > Thanks, > > Severin > > > >
